linux-kernel - Re: [PATCH 2/2] gpio: omap : Add missing clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a5f3a21-c69f-1437-85fb-bd5fafc07f52@ti.com>
Date:   Tue, 1 Aug 2017 14:40:07 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, <ssantosh@...nel.org>,
        <khilman@...nel.org>, <linus.walleij@...aro.org>
CC:     <linux-omap@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: omap : Add missing clk_unprepare().



On 08/01/2017 01:44 AM, Arvind Yadav wrote:
> omap_gpio_probe() can fail here and we must disable clock.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>   drivers/gpio/gpio-omap.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index f8c550de..dbf869f 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1247,6 +1247,8 @@ static int omap_gpio_probe(struct platform_device *pdev)
>   	if (ret) {
>   		pm_runtime_put_sync(dev);
>   		pm_runtime_disable(dev);
> +		if (bank->dbck_flag)
> +			clk_unprepare(bank->dbck);
>   		return ret;
>   	}
>   
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
regards,
-grygorii