linux-kernel - Re: [PATCH] staging: ks7010: fix styling WARNINGs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201708011234.AjCdofLN%fengguang.wu@intel.com>
Date:   Tue, 1 Aug 2017 12:31:34 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ashish Kalra <eashishkalra@...il.com>
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org, wsa@...-dreams.de,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, joe@...ches.com,
        eashishkalra@...il.com
Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs

Hi Ashish,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.13-rc3 next-20170731]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ashish-Kalra/staging-ks7010-fix-styling-WARNINGs/20170801-121331
config: tile-allmodconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All errors (new ones prefixed by >>):

   drivers/staging//ks7010/ks7010_sdio.c: In function 'ks7010_sdio_readb':
   drivers/staging//ks7010/ks7010_sdio.c:77:12: error: invalid storage class for function 'ks7010_sdio_readb'
   drivers/staging//ks7010/ks7010_sdio.c:77:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   drivers/staging//ks7010/ks7010_sdio.c:89:12: error: invalid storage class for function 'ks7010_sdio_read'
   drivers/staging//ks7010/ks7010_sdio.c:98:12: error: invalid storage class for function 'ks7010_sdio_writeb'
   drivers/staging//ks7010/ks7010_sdio.c:110:12: error: invalid storage class for function 'ks7010_sdio_write'
   drivers/staging//ks7010/ks7010_sdio.c:118:13: error: invalid storage class for function 'ks_wlan_hw_sleep_doze_request'
   drivers/staging//ks7010/ks7010_sdio.c:144:13: error: invalid storage class for function 'ks_wlan_hw_sleep_wakeup_request'
   drivers/staging//ks7010/ks7010_sdio.c:191:13: error: invalid storage class for function '_ks_wlan_hw_power_save'
   drivers/staging//ks7010/ks7010_sdio.c:252:12: error: invalid storage class for function 'enqueue_txdev'
   drivers/staging//ks7010/ks7010_sdio.c:290:12: error: invalid storage class for function 'write_to_device'
   drivers/staging//ks7010/ks7010_sdio.c:320:13: error: invalid storage class for function 'tx_device_task'
   drivers/staging//ks7010/ks7010_sdio.c:379:13: error: invalid storage class for function 'rx_event_task'
   drivers/staging//ks7010/ks7010_sdio.c:396:13: error: invalid storage class for function 'ks_wlan_hw_rx'
   drivers/staging//ks7010/ks7010_sdio.c:452:13: error: invalid storage class for function 'ks7010_rw_function'
   drivers/staging//ks7010/ks7010_sdio.c:522:13: error: invalid storage class for function 'ks_sdio_interrupt'
   drivers/staging//ks7010/ks7010_sdio.c:593:12: error: invalid storage class for function 'trx_device_init'
   drivers/staging//ks7010/ks7010_sdio.c:609:13: error: invalid storage class for function 'trx_device_exit'
   drivers/staging//ks7010/ks7010_sdio.c:625:12: error: invalid storage class for function 'ks7010_sdio_update_index'
   drivers/staging//ks7010/ks7010_sdio.c:652:12: error: invalid storage class for function 'ks7010_sdio_data_compare'
   drivers/staging//ks7010/ks7010_sdio.c:680:12: error: invalid storage class for function 'ks7010_upload_firmware'
   drivers/staging//ks7010/ks7010_sdio.c:775:13: error: invalid storage class for function 'ks7010_card_init'
   drivers/staging//ks7010/ks7010_sdio.c:828:13: error: invalid storage class for function 'ks7010_init_defaults'
   drivers/staging//ks7010/ks7010_sdio.c:855:12: error: invalid storage class for function 'ks7010_sdio_probe'
   drivers/staging//ks7010/ks7010_sdio.c:1005:12: error: invalid storage class for function 'send_stop_request'
   drivers/staging//ks7010/ks7010_sdio.c:1032:13: error: invalid storage class for function 'ks7010_sdio_remove'
   drivers/staging//ks7010/ks7010_sdio.c:1100:2: error: initializer element is not constant
   drivers/staging//ks7010/ks7010_sdio.c:1100:2: error: (near initialization for 'ks7010_sdio_driver.probe')
   drivers/staging//ks7010/ks7010_sdio.c:1101:2: error: initializer element is not constant
   drivers/staging//ks7010/ks7010_sdio.c:1101:2: error: (near initialization for 'ks7010_sdio_driver.remove')
   drivers/staging//ks7010/ks7010_sdio.c:1104:1: error: invalid storage class for function 'ks7010_sdio_driver_init'
>> drivers/staging//ks7010/ks7010_sdio.c:1104:1: error: invalid storage class for function '__inittest'
   drivers/staging//ks7010/ks7010_sdio.c:1104:1: warning: 'alias' attribute ignored [-Wattributes]
   drivers/staging//ks7010/ks7010_sdio.c:1104:1: error: invalid storage class for function 'ks7010_sdio_driver_exit'
   drivers/staging//ks7010/ks7010_sdio.c:1104:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>> drivers/staging//ks7010/ks7010_sdio.c:1104:1: error: invalid storage class for function '__exittest'
   drivers/staging//ks7010/ks7010_sdio.c:1104:1: warning: 'alias' attribute ignored [-Wattributes]
   drivers/staging//ks7010/ks7010_sdio.c:1105:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
   drivers/staging//ks7010/ks7010_sdio.c:1108:1: error: expected declaration or statement at end of input
   drivers/staging//ks7010/ks7010_sdio.c:1108:1: warning: no return statement in function returning non-void [-Wreturn-type]
   drivers/staging//ks7010/ks7010_sdio.c: At top level:
   drivers/staging//ks7010/ks7010_sdio.c:69:12: warning: 'ks7010_sdio_readb' defined but not used [-Wunused-function]

vim +/__inittest +1104 drivers/staging//ks7010/ks7010_sdio.c

13a9930d Wolfram Sang 2016-05-31  1096  
4c0d46d2 Wolfram Sang 2016-06-17  1097  static struct sdio_driver ks7010_sdio_driver = {
4c0d46d2 Wolfram Sang 2016-06-17  1098  	.name = "ks7010_sdio",
4c0d46d2 Wolfram Sang 2016-06-17  1099  	.id_table = ks7010_sdio_ids,
4c0d46d2 Wolfram Sang 2016-06-17 @1100  	.probe = ks7010_sdio_probe,
4c0d46d2 Wolfram Sang 2016-06-17  1101  	.remove = ks7010_sdio_remove,
4c0d46d2 Wolfram Sang 2016-06-17  1102  };
4c0d46d2 Wolfram Sang 2016-06-17  1103  
6b0cb0b0 Wolfram Sang 2016-05-31 @1104  module_driver(ks7010_sdio_driver, sdio_register_driver, sdio_unregister_driver);

:::::: The code at line 1104 was first introduced by commit
:::::: 6b0cb0b02ec8c03a16d1bdff4ae79b27874138e1 staging: ks7010: simplify module_init/exit

:::::: TO: Wolfram Sang <wsa+renesas@...g-engineering.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49807 bytes)