linux-kernel - Re: [PATCH] staging: ks7010: fix styling WARNINGs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170801202837.x4cnpu5rr7yt7vfu@mwanda>
Date:   Tue, 1 Aug 2017 23:28:37 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ashish Kalra <eashishkalra@...il.com>
Cc:     gregkh@...uxfoundation.org, wsa@...-dreams.de,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs

The subject is too vague and you need a changelog.

On Tue, Aug 01, 2017 at 05:11:29PM +0100, Ashish Kalra wrote:
> +static int inc_txqhead(struct ks_wlan_private *priv)
> +{
> +	priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE;
> +	return 0;

Just make these void if no one checks the return.

regards,
dan carpenter