linux-kernel - Re: [PATCH 10/28] x86/intel_rdt: Simplify info and base file lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2017 22:34:38 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Vikas Shivappa <vikas.shivappa@...ux.intel.com>
cc:     vikas.shivappa@...el.com, x86@...nel.org,
        linux-kernel@...r.kernel.org, hpa@...or.com, peterz@...radead.org,
        ravi.v.shankar@...el.com, tony.luck@...el.com,
        fenghua.yu@...el.com, eranian@...gle.com, davidcc@...gle.com,
        ak@...ux.intel.com, reinette.chatre@...el.com
Subject: Re: [PATCH 10/28] x86/intel_rdt: Simplify info and base file lists

On Tue, 25 Jul 2017, Vikas Shivappa wrote:
>  	for_each_alloc_enabled_rdt_resource(r) {
> -		kn_subdir = kernfs_create_dir(kn_info, r->name,
> -					      kn_info->mode, r);
> -		if (IS_ERR(kn_subdir)) {
> -			ret = PTR_ERR(kn_subdir);
> -			goto out_destroy;
> -		}
> -		kernfs_get(kn_subdir);
> -		ret = rdtgroup_kn_set_ugid(kn_subdir);
> -		if (ret)
> +		fflags =  r->fflags | RF_CTRL_INFO;
> +		if (rdtgroup_mkdir_info_resdir(r, r->name, fflags))
>  			goto out_destroy;

This returns uninitialized ret. Compiler warnins are overrated....

Thanks,

	tglx