linux-kernel - Re: [PATCH v2 1/4] mm: refactoring TLB gathering API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2017 17:46:14 -0700
From:   Nadav Amit <nadav.amit@...il.com>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:MEMORY MANAGEMENT" <linux-mm@...ck.org>,
        kernel-team <kernel-team@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Tony Luck <tony.luck@...el.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        "David S. Miller" <davem@...emloft.net>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Jeff Dike <jdike@...toit.com>, linux-arch@...r.kernel.org,
        Mel Gorman <mgorman@...hsingularity.net>
Subject: Re: [PATCH v2 1/4] mm: refactoring TLB gathering API

Mel Gorman <mgorman@...hsingularity.net> wrote:

> On Tue, Aug 01, 2017 at 02:56:14PM +0900, Minchan Kim wrote:
>> This patch is ready for solving race problems caused by TLB batch.
> 
> s/is ready/is a preparatory patch/
> 
>> For that, we will increase/decrease TLB flush pending count of
>> mm_struct whenever tlb_[gather|finish]_mmu is called.
>> 
>> Before making it simple, this patch separates architecture specific
>> part and rename it to arch_tlb_[gather|finish]_mmu and generic part
>> just calls it.
>> 
>> It shouldn't change any behavior.
>> 
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Russell King <linux@...linux.org.uk>
>> Cc: Tony Luck <tony.luck@...el.com>
>> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
>> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>> Cc: Jeff Dike <jdike@...toit.com>
>> Cc: linux-arch@...r.kernel.org
>> Cc: Nadav Amit <nadav.amit@...il.com>
>> Cc: Mel Gorman <mgorman@...hsingularity.net>
>> Signed-off-by: Minchan Kim <minchan@...nel.org>
> 
> You could alias arch_generic_tlb_finish_mmu as arch_tlb_gather_mmu
> simiilar to how other arch-generic helpers are done to avoid some
> #ifdeffery but otherwise

Minchan,

Andrew wishes me to send one series that combines both series. What about
this comment from Mel? It seems you intentionally did not want to alias
them...

BTW: patch 4 should add “#include <asm/tlb.h>" - I’ll add it. 

Thanks,
Nadav