[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170802074255.GC2524@dhcp22.suse.cz>
Date: Wed, 2 Aug 2017 09:42:55 +0200
From: Michal Hocko <mhocko@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Johannes Weiner <hannes@...xchg.org>,
Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
Josef Bacik <josef@...icpanda.com>,
Vladimir Davydov <vdavydov.dev@...il.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH 2/2] mm: rename global_page_state to
global_zone_page_state
On Tue 01-08-17 14:05:20, Andrew Morton wrote:
[...]
> WARNING: line over 80 characters
> #187: FILE: mm/page-writeback.c:1408:
> + * global_zone_page_state() too often. So scale it near-sqrt to the safety margin
>
>
> Liveable with, but the code would be quite a bit neater if we had a
> helper function for this.
I vaguely remember somebody wanted to add/consolidate a helper to
convert pages to kB as we have more of those. I wouldn't lose
sleep over "line over 80 characters" warnings in this case. Those lines
are still readable.
--
Michal Hocko
SUSE Labs
Powered by blists - more mailing lists