linux-kernel - Re: [PATCH 3/5] staging/pi433/rf69.h:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <061c039eb1e6896887b9cad71216c4c7-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXcFVl0=-webmailer1@server03.webmailer.webmailer.hosteurope.de>
Date:   Wed, 2 Aug 2017 10:10:38 +0200
From:   "Wolf Entwicklungen" <Marcus.Wolf@...f-Entwicklungen.de>
To:     "Rishabh Hardas" <rishabhhardas@...il.com>
Cc:     gregkh@...uxfoundation.org, linux@...f-entwicklungen.de,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        "Rishabh Hardas" <rishabhhardas@...il.com>
Subject: Re: [PATCH 3/5] staging/pi433/rf69.h:Removed Coding style issues
 from pi433_if.h and other dependencies arising from it.

Reviewed-by: Marcus Wolf <linux@...f-entwicklungen.de>

Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas <rishabhhardas@...il.com>
> ---
>  drivers/staging/pi433/rf69.h | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
> index b81e076..e98e24e 100644
> --- a/drivers/staging/pi433/rf69.h
> +++ b/drivers/staging/pi433/rf69.h
> @@ -29,18 +29,18 @@ int rf69_set_mode(struct spi_device *spi, enum mode mode);
>  int rf69_set_data_mode(struct spi_device *spi, enum dataMode dataMode);
>  int rf69_set_modulation(struct spi_device *spi, enum modulation modulation);
>  enum modulation rf69_get_modulation(struct spi_device *spi);
> -int rf69_set_modulation_shaping(struct spi_device *spi, enum modShaping modShaping);
> +int rf69_set_modulation_shaping(struct spi_device *spi, enum mod_shaping modShaping);
>  int rf69_set_bit_rate(struct spi_device *spi, u16 bitRate);
>  int rf69_set_deviation(struct spi_device *spi, u32 deviation);
>  int rf69_set_frequency(struct spi_device *spi, u32 frequency);
> -int rf69_set_amplifier_0(struct spi_device *spi, enum optionOnOff optionOnOff);
> -int rf69_set_amplifier_1(struct spi_device *spi, enum optionOnOff optionOnOff);
> -int rf69_set_amplifier_2(struct spi_device *spi, enum optionOnOff optionOnOff);
> +int rf69_set_amplifier_0(struct spi_device *spi, enum option_on_off optionOnOff);
> +int rf69_set_amplifier_1(struct spi_device *spi, enum option_on_off optionOnOff);
> +int rf69_set_amplifier_2(struct spi_device *spi, enum option_on_off optionOnOff);
>  int rf69_set_output_power_level(struct spi_device *spi, u8 powerLevel);
> -int rf69_set_pa_ramp(struct spi_device *spi, enum paRamp paRamp);
> -int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance antennaImpedance);
> -int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain);
> -enum lnaGain rf69_get_lna_gain(struct spi_device *spi);
> +int rf69_set_pa_ramp(struct spi_device *spi, enum pa_ramp paRamp);
> +int rf69_set_antenna_impedance(struct spi_device *spi, enum antenna_impedance antennaImpedance);
> +int rf69_set_lna_gain(struct spi_device *spi, enum lnagain lnaGain);
> +enum lnagain rf69_get_lna_gain(struct spi_device *spi);
>  int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent);
>  int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent dccPercent);
>  int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPercent dccPercent);
> @@ -48,7 +48,7 @@ int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 expone
>  int rf69_set_bandwidth_during_afc(struct spi_device *spi, enum mantisse mantisse, u8 exponent);
>  int rf69_set_ook_threshold_type(struct spi_device *spi, enum thresholdType thresholdType);
>  int rf69_set_ook_threshold_step(struct spi_device *spi, enum thresholdStep thresholdStep);
> -int rf69_set_ook_threshold_dec(struct spi_device *spi, enum thresholdDecrement thresholdDecrement);
> +int rf69_set_ook_threshold_dec(struct spi_device *spi, enum threshold_decrement thresholdDecrement);
>  int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value);
>  bool rf69_get_flag(struct spi_device *spi, enum flag flag);
>  int rf69_reset_flag(struct spi_device *spi, enum flag flag);
> @@ -56,18 +56,18 @@ int rf69_set_rssi_threshold(struct spi_device *spi, u8 threshold);
>  int rf69_set_rx_start_timeout(struct spi_device *spi, u8 timeout);
>  int rf69_set_rssi_timeout(struct spi_device *spi, u8 timeout);
>  int rf69_set_preamble_length(struct spi_device *spi, u16 preambleLength);
> -int rf69_set_sync_enable(struct spi_device *spi, enum optionOnOff optionOnOff);
> +int rf69_set_sync_enable(struct spi_device *spi, enum option_on_off optionOnOff);
>  int rf69_set_fifo_fill_condition(struct spi_device *spi, enum fifoFillCondition fifoFillCondition);
>  int rf69_set_sync_size(struct spi_device *spi, u8 sync_size);
>  int rf69_set_sync_tolerance(struct spi_device *spi, u8 syncTolerance);
>  int rf69_set_sync_values(struct spi_device *spi, u8 syncValues[8]);
>  int rf69_set_packet_format(struct spi_device * spi, enum packetFormat packetFormat);
> -int rf69_set_crc_enable(struct spi_device *spi, enum optionOnOff optionOnOff);
> -int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering addressFiltering);
> +int rf69_set_crc_enable(struct spi_device *spi, enum option_on_off optionOnOff);
> +int rf69_set_adressFiltering(struct spi_device *spi, enum address_filtering addressFiltering);
>  int rf69_set_payload_length(struct spi_device *spi, u8 payloadLength);
>  u8  rf69_get_payload_length(struct spi_device *spi);
>  int rf69_set_node_address(struct spi_device *spi, u8 nodeAddress);
>  int rf69_set_broadcast_address(struct spi_device *spi, u8 broadcastAddress);
> -int rf69_set_tx_start_condition(struct spi_device *spi, enum txStartCondition txStartCondition);
> +int rf69_set_tx_start_condition(struct spi_device *spi, enum tx_start_condition txStartCondition);
>  int rf69_set_fifo_threshold(struct spi_device *spi, u8 threshold);
>  int rf69_set_dagc(struct spi_device *spi, enum dagc dagc);
>
> --
> 2.7.4
>
>
>