linux-kernel - Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170802081923.j5whbxqaztj3fit5@mwanda>
Date:   Wed, 2 Aug 2017 11:19:24 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Rishabh Hardas <rishabhhardas@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux@...f-Entwicklungen.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from
 pi433_if.h and other dependencies arising from it.

The subject is too long.

On Wed, Aug 02, 2017 at 01:01:55AM +0530, Rishabh Hardas wrote:
> This is a 5 patch series which solves coding style issues
> as marked by checkpatch.pl in the file pi433_if.h and
> contains changes that have to be made in other files as a
> consequence of the changes made in pi433_if.h

This looks like the description of 5 patches, but that should be in the
[PATCH 0/5] summary.  What we want here is the description of this
patch.

This patch does too many things, deleting stuff, breaking up long lines,
changing comments and renaming enums.  It should be 4 patches:
[patch 1] delete stuff
[patch 2] break long lines
...
etc.

regards,
dan carpenter