lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Aug 2017 10:24:03 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: "Gustavo A. R. Silva" <garsilva@...eddedor.com> Cc: Wim Van Sebroeck <wim@...ana.be>, Guenter Roeck <linux@...ck-us.net>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, LINUXWATCHDOG <linux-watchdog@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] watchdog: coh901327_wdt: constify watchdog_ops structure On Sat, Jul 8, 2017 at 2:33 AM, Gustavo A. R. Silva <garsilva@...eddedor.com> wrote: > Check for watchdog_ops structures that are only stored in the ops field of > a watchdog_device structure. This field is declared const, so watchdog_ops > structures that have this property can be declared as const also. > > This issue was detected using Coccinelle and the following semantic patch: > > @r > disable optional_qualifier@ > identifier i; > position p; > @@ > static struct watchdog_ops i@p = { ... }; > > @ok@ > identifier r.i; > struct watchdog_device e; > position p; > @@ > e.ops = &i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct watchdog_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct watchdog_ops i = { ... }; > > Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com> Acked-by: Linus Walleij <linus.walleij@...aro.org> Yours, Linus Walleij
Powered by blists - more mailing lists