linux-kernel - Re: [PATCH] pinctrl: samsung: Remove unneeded local variable initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbMBgOad3Vidccu46GhF9ccYwGqPjE19N_AvnRn0S_qMg@mail.gmail.com>
Date:   Wed, 2 Aug 2017 10:45:07 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Tomasz Figa <tomasz.figa@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Kukjin Kim <kgene@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: samsung: Remove unneeded local variable initialization

On Tue, Jul 18, 2017 at 7:43 PM, Krzysztof Kozlowski <krzk@...nel.org> wrote:

> Two local variables (shift and reg_con) were initialized to unused
> values - they were overwritten just few lines after.  Getting rid of
> this unused initialization allows dropping other variables and
> compacting slightly the code.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Looks good to me, I expect to get this from you in a pull request.

Yours,
Linus Walleij