linux-kernel - Re: [RFC PATCH] ARM: dts: stm32: change pinctrl bindings definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Aug 2017 11:32:33 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Alexandre TORGUE <alexandre.torgue@...com>
Cc:     Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ARM: dts: stm32: change pinctrl bindings definition

On Mon, Jul 17, 2017 at 1:00 PM, Alexandre TORGUE
<alexandre.torgue@...com> wrote:

> Initially each pin was declared in "include/dt-bindings/stm32f429-pinfunc.h"
> and each definition contained SOC names (ex: STM32F429_PA9_FUNC_USART1_TX).
> Since this approach was approved, the number of supported MCU has
> increased (STM32F429/STM32F469/STM32f746/STM32H743). To avoid to add a new
> file in "include/dt-bindings" each time a new STM32 SOC arrives I propose
> a new approach which consist to use a macro to define pin muxing in device
> tree. All STM32 DT will use the common macro to define pinmux. Furthermore, it
> will make easy maintenance and integration of new SOC.
>
> To check that patch generate same dtb than befrore I used dtc binary to (re)generate dts files
> (before and after apply the series).
> Example on stm32f469-disco:
>
> ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-after.dts
> stm32f469-disco-after.dtb
>
> ./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-before.dts
> stm32f469-disco-before.dtb
>
> Then diff -u stm32f469-disco-before.dts stm32f469-disco-after.dts

Looks OK to me. I guess it should all be merged into ARM SoC.

Acked-by: Linus Walleij <linus.walleij@...aro.org>
for the final version.

Yours,
Linus Walleij