linux-kernel - Re: [PATCH] fbcon: mark dummy functions 'inline'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKMK7uHkyCh+2rUaV_4k5gyGWfECWnYcSh6BMnDDBqdPgNYF8Q@mail.gmail.com>
Date:   Wed, 2 Aug 2017 12:02:50 +0200
From:   Daniel Vetter <daniel.vetter@...ll.ch>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sean Paul <seanpaul@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fbcon: mark dummy functions 'inline'

On Wed, Aug 2, 2017 at 11:38 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The newly introduced fb_console_init/exit declarations have a
> dummy alternative that is marked 'static' in the header but not
> inline, leading to a warning whenever the header gets included:
>
> In file included from drivers/video/fbdev/core/fbmem.c:35:0:
> include/linux/fbcon.h:9:13: error: 'fb_console_exit' defined but not used [-Werror=unused-function]
>
> This adds the intended 'inline'.
>
> Fixes: 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

> ---
>  include/linux/fbcon.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fbcon.h b/include/linux/fbcon.h
> index 0fac6305d51c..f68a7db14165 100644
> --- a/include/linux/fbcon.h
> +++ b/include/linux/fbcon.h
> @@ -5,8 +5,8 @@
>  void __init fb_console_init(void);
>  void __exit fb_console_exit(void);
>  #else
> -static void fb_console_init(void) {}
> -static void fb_console_exit(void) {}
> +static inline void fb_console_init(void) {}
> +static inline void fb_console_exit(void) {}
>  #endif
>
>  #endif /* _LINUX_FBCON_H */
> --
> 2.9.0
>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch