linux-kernel - Re: [PATCH net 5/7] gtp: Initialize 64-bit per-cpu stats correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170802104610.GA2566@salvia>
Date:   Wed, 2 Aug 2017 12:46:10 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        Harald Welte <laforge@...monks.org>,
        "open list:GTP (GPRS Tunneling Protocol)" 
        <osmocom-net-gprs@...ts.osmocom.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 5/7] gtp: Initialize 64-bit per-cpu stats correctly

On Tue, Aug 01, 2017 at 12:11:10PM -0700, Florian Fainelli wrote:
> On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a
> lockdep splat indicating this seqcount is not correctly initialized, fix
> that by using netdev_alloc_pcpu_stats() instead of an open coded
> allocation.
> 
> Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Pablo Neira Ayuso <pablo@...filter.org>

Thanks!