[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdaBn2KV0sq4U+TfKmE-SoHtLbV+k6NBr=BbQ0aFRLbsDA@mail.gmail.com>
Date: Wed, 2 Aug 2017 13:59:47 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: versatile: remove unnecessary static in realview_soc_probe()
On Thu, Jul 20, 2017 at 12:40 AM, Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
> Remove unnecessary static on local variables syscon_regmap.
> Such variables are initialized before being used, on every
> execution path throughout the functions. The static has no
> benefit and, removing it reduces the object file size.
>
> This issue was detected using Coccinelle and the following
> semantic patch:
>
> @bad exists@
> position p;
> identifier x;
> type T;
> @@
>
> static T x@p;
> ...
> x = <+...x...+>
>
> @@
> identifier x;
> expression e;
> type T;
> position p != bad.p;
> @@
>
> -static
> T x@p;
> ... when != x
> when strict
> ?x = e;
>
> In the following log you can see the difference in the object file size.
> This log is the output of the size command, before and after the code
> change:
>
> before:
> text data bss dec hex filename
> 3339 2104 128 5571 15c3 drivers/soc/versatile/soc-realview.o
>
> after:
> text data bss dec hex filename
> 3321 2048 64 5433 1539 drivers/soc/versatile/soc-realview.o
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Acked-by: Linus Walleij <linus.walleij@...aro.org>
You probably want to funnel this patch through the ARM SoC tree.
(If nothing else works, send as separate patch to arm@...nel.org)
Yours,
Linus Walleij
Powered by blists - more mailing lists