linux-kernel - Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170802121426.l3wmnyeeoig3p44u@mwanda>
Date:   Wed, 2 Aug 2017 15:14:26 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Marcus Wolf <marcus.wolf@...f-entwicklungen.de>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: remove some macros, introduce some
 inline functions

On Wed, Aug 02, 2017 at 02:07:37PM +0200, Marcus Wolf wrote:
> Hi Dan,
> 
> I get your point and I understand, that there need to be rules to
> simplify the life for the maintainers...
> 
> But I honestly must confess, that at the moment, I don't have the
> time for doing that. I am into two customer projects, that keep me
> very busy these weeks.
> 
> The only thing, I can offer, is to remove all the lines, dealing 
> with the #ifdef DEBUG and leave the rest, as it is and send it again.
> Then all other changes are related to the move from macro to inline...
> If that helps, please let me know.
> 
> If it needs further fragmentation, it'll take something like half 
> a day / a day. I most probably can spent that day end of August, 
> begin of September the earliest.
> 

One trick that might help is you can just use `git citool` and highlight
all the rmw() lines, add selected lines to the commit, then commit that
as one patch.  Repeat for all five patches.

The kernel process does kind of have a steep learning with redoing
patches...  Sorry about that.

regards,
dan carpenter