linux-kernel - Re: [PATCH] z3fold: use per-cpu unbuddied lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201708022101.VfFg8fxz%fengguang.wu@intel.com>
Date:   Wed, 2 Aug 2017 21:50:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vitaly Wool <vitalywool@...il.com>
Cc:     kbuild-all@...org, Linux-MM <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org, Dan Streetman <ddstreet@...e.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Oleksiy.Avramchenko@...y.com
Subject: Re: [PATCH] z3fold: use per-cpu unbuddied lists

Hi Vitaly,

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.13-rc3 next-20170802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vitaly-Wool/z3fold-use-per-cpu-unbuddied-lists/20170802-211153
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-randconfig-x019-201731 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   mm/z3fold.c: In function 'free_pages_work':
>> mm/z3fold.c:310:3: error: implicit declaration of function 'cond_resched' [-Werror=implicit-function-declaration]
      cond_resched();
      ^~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/cond_resched +310 mm/z3fold.c

   292	
   293	static void free_pages_work(struct work_struct *w)
   294	{
   295		struct z3fold_pool *pool = container_of(w, struct z3fold_pool, work);
   296	
   297		spin_lock(&pool->stale_lock);
   298		while (!list_empty(&pool->stale)) {
   299			struct z3fold_header *zhdr = list_first_entry(&pool->stale,
   300							struct z3fold_header, buddy);
   301			struct page *page = virt_to_page(zhdr);
   302	
   303			list_del(&zhdr->buddy);
   304			if (WARN_ON(!test_bit(PAGE_STALE, &page->private)))
   305				continue;
   306			clear_bit(NEEDS_COMPACTING, &page->private);
   307			spin_unlock(&pool->stale_lock);
   308			cancel_work_sync(&zhdr->work);
   309			free_z3fold_page(page);
 > 310			cond_resched();
   311			spin_lock(&pool->stale_lock);
   312		}
   313		spin_unlock(&pool->stale_lock);
   314	}
   315	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27394 bytes)