linux-kernel - Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKMK7uGRPfw2takjMCZ0XwA+cED7+SovXpCTLwtmT3mWQrsKMw@mail.gmail.com>
Date:   Wed, 2 Aug 2017 16:17:33 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Cihangir Akturk <cakturk@...il.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Michael Thayer <michael.thayer@...cle.com>,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference

On Wed, Aug 2, 2017 at 3:47 PM, Cihangir Akturk <cakturk@...il.com> wrote:
> On Wed, Aug 02, 2017 at 02:38:50PM +0200, Daniel Vetter wrote:
>> On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@...il.com> wrote:
>> > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should
>> > not be used by new code.
>> >
>> > This patch fixes the following warning reported by coccinelle:
>> >
>> > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put
>> > helpers to reference and dereference obj
>> >
>> > Signed-off-by: Cihangir Akturk <cakturk@...il.com>
>>
>> Care to do this for all the drm drivers, not just the single one in staging?
>
> Sure, I'll send a v2 shortly as you suggested.

Patch per driver would be better I think, there's probably going to be
a _lot_ of hits.

Thanks, Daniel

>
> Thanks.
>
>>
>> Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches
>> also go to dri-devel?
>>
>> Thanks, Daniel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch