linux-kernel - Re: [PATCH] misc: Kconfig: fix missing tristate prompt and add help for LIS3LV02D

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B529AE22-2336-4722-A82D-8B0FF442FD34@goldelico.com>
Date:   Wed, 2 Aug 2017 18:13:04 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Letux-kernel@...nphoenux.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc: Kconfig: fix missing tristate prompt and add help for LIS3LV02D

Hi,

> Am 02.08.2017 um 18:06 schrieb Arnd Bergmann <arnd@...db.de>:
> 
> On Wed, Aug 2, 2017 at 5:57 PM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>> On Wed, Aug 02, 2017 at 04:05:36PM +0200, H. Nikolaus Schaller wrote:
>>> +     help
>>> +       If you say yes here, you get support for the STM
>>> +       LIS3LV02D sensor.
>> 
>> No name for what the module is called?
> 
> Not sure if that's even relevant here, as the symbol only controls the
> base driver that doesn't do anything by itself, while the LIS3_SPI/LIS3_I2C
> Kconfig symbols are the interesting ones.
> 
> The help text should also reflect that I think and explain why you would
> enable the symbol in the first place (which the patch description doesn't
> either).

Hm. I start to no longer understand how this LIS302 is configured at all
and what SENSORS_LIS3LV02D is good for.

I just noticed while preparing some other driver/misc that there is no
description in the drivers/misc/Kconfig file while all other CONFIGs have some.

But configuring LIS302 works (we have some GTA04 boards where one is installed).

BR and thanks,
Nikolaus