linux-kernel - Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1501696935.29303.367.camel@linux.intel.com>
Date:   Wed, 02 Aug 2017 21:02:15 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Sean Wang <sean.wang@...iatek.com>,
        "arnd.bergmann" <arnd.bergmann@...aro.org>
Cc:     robh+dt@...nel.org, gregkh@...uxfoundation.org, jslaby@...e.com,
        jan.kiszka@...mens.com, heikki.krogerus@...ux.intel.com,
        hpeter@...il.com, vigneshr@...com, matthias.bgg@...il.com,
        devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF
 controller

On Thu, 2017-08-03 at 01:37 +0800, Sean Wang wrote:
> On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote:
> > On Thu, 2017-08-03 at 01:05 +0800, sean.wang@...iatek.com wrote:
> > > From: Sean Wang <sean.wang@...iatek.com>
> > > 
> > > This patchset introduces the support for MediaTek BTIF controller.
> > > 
> > > MediaTek BTIF controller is the serial interface similar to UART
> > > but
> > > it
> > > works only as the digital device which is mainly used to
> > > communicate
> > > with
> > > the connectivity module also called CONNSYS inside the SoC which
> > > could
> > > be
> > > mostly found on those MediaTek SoCs with Bluetooth feature.
> > > 
> > > And the controller is made as being compatible with the 8250
> > > register
> > > layout so it tends to be integrated with existing 8250 core driver
> > > and
> > > have no requirement for the modem configuration additionally such
> > > as
> > > the
> > > baud rate calculation and assignment.

+Cc: Arnd.

> > Why it requires a separate driver?
> > 
> > 8250_of is for DT enabled drivers.
> > 
> 
> Hi, Andy
> 
> thanks for your information
> 
> the hardware is not completely identical to 8250 device, 
> it has extra registers belonged to platform control such as internal
> loopback, dma disable/enable, sleep/wakeup setup and so on, so I
> create
> it as a separate driver.

Over all 200+ LOCs I didn't see any of the above except loopback, which
is one property that can be easily added to 8250_of.c.

Moreover, if you have more code coming I would suggest you to split
8250_of to library and driver parts and re-use stuff from there.

Arnd, what is your opinion about new 8250 OF based drivers?

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy