linux-kernel - RE: [PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM4PR0401MB1699B3AAF1609CB04AF01E668FB00@AM4PR0401MB1699.eurprd04.prod.outlook.com>
Date:   Wed, 2 Aug 2017 18:54:58 +0000
From:   Leo Li <leoyang.li@....com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bhumika Goyal <bhumirks@...il.com>
Subject: RE: [PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0_desc



> -----Original Message-----
> From: Julia Lawall [mailto:Julia.Lawall@...6.fr]
> Sent: Wednesday, August 02, 2017 10:29 AM
> To: Leo Li <leoyang.li@....com>
> Cc: kernel-janitors@...r.kernel.org; Felipe Balbi <balbi@...nel.org>; Greg
> Kroah-Hartman <gregkh@...uxfoundation.org>; linux-usb@...r.kernel.org;
> linuxppc-dev@...ts.ozlabs.org; linux-kernel@...r.kernel.org; Bhumika Goyal
> <bhumirks@...il.com>
> Subject: [PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0_desc
> 
> qe_ep0_desc is only passed as the second argument to qe_ep_init, which is
> const, so qe_ep0_desc can be const too.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Li Yang <leoyang.li@....com>

> 
> ---
> I got a lot of warnings when compiling this file, but none seemed to be related
> to the change.
> 
>  drivers/usb/gadget/udc/fsl_qe_udc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c
> b/drivers/usb/gadget/udc/fsl_qe_udc.c
> index 303328ce..a3e72d6 100644
> --- a/drivers/usb/gadget/udc/fsl_qe_udc.c
> +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c
> @@ -62,7 +62,7 @@
>  	"ep3",
>  };
> 
> -static struct usb_endpoint_descriptor qe_ep0_desc = {
> +static const struct usb_endpoint_descriptor qe_ep0_desc = {
>  	.bLength =		USB_DT_ENDPOINT_SIZE,
>  	.bDescriptorType =	USB_DT_ENDPOINT,
>