linux-kernel - Re: [Patch V3] crypto: x86/sha1 : Fix reads beyond the number of blocks passed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <964539021.65400093.1501701530053.JavaMail.zimbra@redhat.com>
Date:   Wed, 2 Aug 2017 15:18:50 -0400 (EDT)
From:   Jan Stancek <jstancek@...hat.com>
To:     Megha Dey <megha.dey@...el.com>
Cc:     herbert@...dor.apana.org.au,
        tim c chen <tim.c.chen@...ux.intel.com>, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        ilya albrekht <ilya.albrekht@...el.com>
Subject: Re: [Patch V3] crypto: x86/sha1 : Fix reads beyond the number of
 blocks passed




----- Original Message -----
> On Wed, 2017-08-02 at 10:13 -0700, Megha Dey wrote:
> > It was reported that the sha1 AVX2 function(sha1_transform_avx2) is
> > reading ahead beyond its intended data, and causing a crash if the next
> > block is beyond page boundary:
> > http://marc.info/?l=linux-crypto-vger&m=149373371023377
> > 
> > This patch makes sure that there is no overflow for any buffer length.
> > 
> > It passes the tests written by Jan Stancek that revealed this problem:
> > https://github.com/jstancek/sha1-avx2-crash
> 
> Hi Jan,
> 
> Is it ok to add your Tested-by?

Yes, v3 patch is exactly the diff I was testing.

Regards,
Jan