linux-kernel - [PATCH 5/5] test_kmod: fix small memory leak on filesystem tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170802211450.27928-6-mcgrof@kernel.org>
Date:   Wed,  2 Aug 2017 14:14:50 -0700
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     akpm@...ux-foundation.org
Cc:     dmitry.torokhov@...il.com, keescook@...omium.org, jeyu@...hat.com,
        rusty@...tcorp.com.au, mmarek@...e.com, pmladek@...e.com,
        mbenes@...e.cz, jpoimboe@...hat.com, ebiederm@...ssion.com,
        shuah@...nel.org, dan.carpenter@...cle.com,
        colin.king@...onical.com, dcb314@...mail.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Luis R . Rodriguez" <mcgrof@...nel.org>
Subject: [PATCH 5/5] test_kmod: fix small memory leak on filesystem tests

From: Dan Carpenter <dan.carpenter@...cle.com>

The break was in the wrong place so file system tests don't work as
intended, leaking memory at each test switch.

Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Reported-by: David Binderman <dcb314@...mail.com>
[mcgrof: massaged commit subject, noted memory leak issue without the fix]
Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
---
 lib/test_kmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index 1bc06bbfc97a..ff9148969b92 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -746,11 +746,11 @@ static int trigger_config_run_type(struct kmod_test_device *test_dev,
 						      strlen(test_str));
 		break;
 	case TEST_KMOD_FS_TYPE:
-		break;
 		kfree_const(config->test_fs);
 		config->test_driver = NULL;
 		copied = config_copy_test_fs(config, test_str,
 					     strlen(test_str));
+		break;
 	default:
 		mutex_unlock(&test_dev->config_mutex);
 		return -EINVAL;
-- 
2.11.0