[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170802211707.28020-3-mcgrof@kernel.org>
Date: Wed, 2 Aug 2017 14:17:07 -0700
From: "Luis R. Rodriguez" <mcgrof@...nel.org>
To: akpm@...ux-foundation.org
Cc: dmitry.torokhov@...il.com, keescook@...omium.org, jeyu@...hat.com,
rusty@...tcorp.com.au, mmarek@...e.com, pmladek@...e.com,
mbenes@...e.cz, jpoimboe@...hat.com, ebiederm@...ssion.com,
shuah@...nel.org, dan.carpenter@...cle.com,
colin.king@...onical.com, dcb314@...mail.com,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
"Luis R . Rodriguez" <mcgrof@...nel.org>
Subject: [PATCH 2/2] test_kmod: flip INT checks to be consistent
From: Dan Carpenter <dan.carpenter@...cle.com>
Most checks will check for min and then max, except the int check.
Flip the checks to be consistent with the other code.
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
[mcgrof: massaged commit log]
Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
---
lib/test_kmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index 67fc7b9f41e3..fba78d25e825 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -946,7 +946,7 @@ static int test_dev_config_update_int(struct kmod_test_device *test_dev,
if (ret)
return ret;
- if (new > INT_MAX || new < INT_MIN)
+ if (new < INT_MIN || new > INT_MAX)
return -EINVAL;
mutex_lock(&test_dev->config_mutex);
--
2.11.0
Powered by blists - more mailing lists