[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170802213948.GJ20308@bhelgaas-glaptop.roam.corp.google.com>
Date: Wed, 2 Aug 2017 16:39:49 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Bjorn Andersson <bjorn.andersson@...aro.org>
Cc: Stanimir Varbanov <svarbanov@...sol.com>,
Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] PCI: qcom: Don't unroll init if init fails
On Sat, Jul 15, 2017 at 11:41:53PM -0700, Bjorn Andersson wrote:
> When the init op fails it will restore the state of the resources, so we
> should not disable them one more time when this happens.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
Stanimir, any opinion on this and the following patch?
> ---
> drivers/pci/dwc/pcie-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index d15657dc3990..7b703741a3fd 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -901,7 +901,7 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
>
> ret = pcie->ops->init(pcie);
> if (ret)
> - goto err_deinit;
> + return ret;
>
> ret = phy_power_on(pcie->phy);
> if (ret)
> --
> 2.12.0
>
Powered by blists - more mailing lists