linux-kernel - Re: [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4 digit octal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9775443d-5b4e-4022-51a4-af678489d1a2@roeck-us.net>
Date:   Wed, 2 Aug 2017 22:15:19 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     SZ Lin <sz.lin@...a.com>, wim@...ana.be
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4
 digit octal

On 07/29/2017 02:15 AM, SZ Lin wrote:
> ERROR: Use 4 digit octal (0777) not decimal permissions
> 
> This error was detected by checkpatch.pl
> 
> Signed-off-by: SZ Lin <sz.lin@...a.com>

I think checkpatch is overdoing it a bit here. There are more than 2,000 of those.
Plus, I really don't see the value in this change.

Guenter

> ---
>   drivers/watchdog/moxart_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
> index 2c4a73d1e214..05684aa89b88 100644
> --- a/drivers/watchdog/moxart_wdt.c
> +++ b/drivers/watchdog/moxart_wdt.c
> @@ -170,7 +170,7 @@ static struct platform_driver moxart_wdt_driver = {
>   };
>   module_platform_driver(moxart_wdt_driver);
>   
> -module_param(heartbeat, int, 0);
> +module_param(heartbeat, int, 0000);
>   MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds");
>   
>   MODULE_DESCRIPTION("MOXART watchdog driver");
>