linux-kernel - Re: [PATCH v7 12/12] pinctrl: dt-bindings: add bindings for Rockchip RK805 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYrG1sUcfaP8xVWNKjqWB8jCsZ0yPFjP-DMkT1ni+V37w@mail.gmail.com>
Date:   Thu, 3 Aug 2017 09:42:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Joseph Chen <chenjh@...k-chips.com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Tao Huang <huangtao@...k-chips.com>,
        Tony Xie <tony.xie@...k-chips.com>, zhangqing@...k-chips.com,
        David Wu <wdc@...k-chips.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        w.egorov@...tec.de, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Linux Input <linux-input@...r.kernel.org>
Subject: Re: [PATCH v7 12/12] pinctrl: dt-bindings: add bindings for Rockchip
 RK805 PMIC

On Fri, Jul 21, 2017 at 1:19 PM, Joseph Chen <chenjh@...k-chips.com> wrote:

(...)

> +Following are optional properties defined as pinmux DT binding document
> +<pinctrl-bindings.txt>. Absence of properties will leave the configuration
> +on default.
> +       function,
> +       output-low,
> +       output-high.
> +
> +Valid values for function properties are: gpio.
> +
> +Theres is also not customised properties for any GPIO.
> +
> +Example:
> +--------
> +rk805: rk805@18 {
> +       compatible = "rockchip,rk805";
> +       ...
> +       gpio-controller;
> +       #gpio-cells = <2>;
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pmic_int_l>, <&rk805_default>;
> +
> +       rk805_default: pinmux {
> +               gpio01 {
> +                       pins = "gpio0", "gpio1";
> +                       function = "gpio";
> +                       output-high.

That should be a semicolon.

With that fixed:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij