linux-kernel - Re: qtfnmac: Tidy up DMA mask setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170803095733.B5D09607A3@smtp.codeaurora.org>
Date:   Thu,  3 Aug 2017 09:57:33 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Robin Murphy <robin.murphy@....com>
Cc:     imitsyanko@...ntenna.com, avinashp@...ntenna.com,
        smatyukevich@...ntenna.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: qtfnmac: Tidy up DMA mask setting

Robin Murphy <robin.murphy@....com> wrote:

> As the only caller of dma_supported() outside of DMA API internals, the
> qtfnmac driver stands out and invites scrutiny. Thankfully, it's not
> being used for evil, but it is entirely redundant, since it open-codes a
> check that the DMA mask setting functions are going to perform anyway.
> In fact, the whole qtnf_pcie_init_dma_mask() function is nothing more
> than a rather long-winded implementation of dma_set_mask_and_coherent(),
> so let's just use that directly.
> 
> Signed-off-by: Robin Murphy <robin.murphy@....com>
> Acked-by: Sergey Matyukevich <sergey.matyukevich.os@...ntenna.com>

There's a typo in title prefix, I'll fix it to "qtnfmac:".

-- 
https://patchwork.kernel.org/patch/9859961/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches