linux-kernel - Re: [PATCH] mmc: sdhci-msm: add static to local functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2017 13:31:50 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mmc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] mmc: sdhci-msm: add static to local functions

On 31/07/17 15:00, Masahiro Yamada wrote:
> Detected by sparse.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
> 
>  drivers/mmc/host/sdhci-msm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 9d601dc0d646..f35db061ee4c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -611,7 +611,7 @@ static void msm_hc_select_hs400(struct sdhci_host *host)
>   * HS400 - divided clock (free running MCLK/2)
>   * All other modes - default (free running MCLK)
>   */
> -void sdhci_msm_hc_select_mode(struct sdhci_host *host)
> +static void sdhci_msm_hc_select_mode(struct sdhci_host *host)
>  {
>  	struct mmc_ios ios = host->mmc->ios;
>  
> @@ -1049,7 +1049,7 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host)
>   * instead directly control the GCC clock as per
>   * HW recommendation.
>   **/
> -void __sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)
> +static void __sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)
>  {
>  	u16 clk;
>  	/*
>