linux-kernel - Re: [PATCH 0/4] constify hid attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1708031340440.30597@cbobk.fhfr.pm>
Date:   Thu, 3 Aug 2017 13:41:33 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
cc:     benjamin.tissoires@...hat.com, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH 0/4] constify hid attribute_group structures.

On Thu, 3 Aug 2017, Arvind Yadav wrote:

> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
> 
> Arvind Yadav (5):
>   [PATCH 1/4] HID: multitouch: constify attribute_group structures.
>   [PATCH 2/4] HID: sensor: constify attribute_group structures.
>   [PATCH 3/4] HID: logitech-hidpp: constify attribute_group structures.
>   [PATCH 4/4] HID: ntrig: constify attribute_group structures.
> 
>  drivers/hid/hid-logitech-hidpp.c |  2 +-
>  drivers/hid/hid-multitouch.c     |  2 +-
>  drivers/hid/hid-ntrig.c          |  2 +-
>  drivers/hid/hid-sensor-custom.c  |  2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

I've applied this to for-4.14/constify-attribute_group branch, but please 
fix your workflow for any furture submissions -- the series wasn't 
properly threaded, only patch 1/4 got threaded to 0/4 mail, others were 
missing References/In-reply-to header completely.

Thanks,

-- 
Jiri Kosina
SUSE Labs