linux-kernel - Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bc44983-64ef-38ff-2a29-fa6c61247ccc@redhat.com>
Date:   Thu, 3 Aug 2017 13:53:06 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Radim Krčmář <rkrcmar@...hat.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers

On 02.08.2017 22:41, Radim Krčmář wrote:
> This series does the generalization that we've spoken about recently
> Might be a good time to change the function names as well.
> 
> 
> Radim Krčmář (2):
>   KVM: x86: generalize guest_cpuid_has_ helpers
>   KVM: x86: use general helpers for some cpuid manipulation
> 
>  arch/x86/kvm/cpuid.h | 205 ++++++++++++++++++---------------------------------
>  arch/x86/kvm/mmu.c   |   7 +-
>  arch/x86/kvm/mtrr.c  |   2 +-
>  arch/x86/kvm/svm.c   |   7 +-
>  arch/x86/kvm/vmx.c   |  33 ++++-----
>  arch/x86/kvm/x86.c   |  52 ++++++-------
>  6 files changed, 116 insertions(+), 190 deletions(-)
> 

These numbers speak for themselves.

I really like this cleanup!

Had a quick look over the patches, nothing jumped at me.

-- 

Thanks,

David