linux-kernel - Re: [PATCH 3/3] PCI: qcom: Allow post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df93be6a-eaf1-aebd-e5b2-855a32adb576@mm-sol.com>
Date:   Thu, 3 Aug 2017 15:45:00 +0300
From:   Stanimir Varbanov <svarbanov@...sol.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] PCI: qcom: Allow post_init to fail

Bjorn, thanks for the patch!

On 07/16/2017 09:42 AM, Bjorn Andersson wrote:
> host_init should detect and propagate errors from post_init.
> 
> In addition, by acknowleding that post_init can fail we must disable the
> post_init resources in a step separate from the deinit, so that we don't
> try to disable the post_init resources a second time.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>  drivers/pci/dwc/pcie-qcom.c | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)

The patch looks good to me,

Acked-by: Stanimir Varbanov <svarbanov@...sol.com>

regards,
Stan