linux-kernel - Re: [PATCH 1/2] bitops: Avoid integer overflow warning in GENMASK_ULL

Open Source and information security mailing list archives

Message-ID: <20170803132456.mwrt6yspkbqxcffw@yury-thinkpad>
Date:   Thu, 3 Aug 2017 16:24:56 +0300
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     zijun_hu <zijun_hu@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Mark Rutland <mark.rutland@....com>,
        Laura Abbott <labbott@...hat.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org, Greg Hackmann <ghackmann@...gle.com>,
        Doug Anderson <dianders@...omium.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] bitops: Avoid integer overflow warning in GENMASK_ULL

On Wed, Aug 02, 2017 at 03:51:58PM -0700, Matthias Kaehlcke wrote:
> GENMASK_ULL performs a left-shift of (~0ULL), which technically
> results in an integer overflow. clang raises a warning about
> this if the overflow occurs in a preprocessor expression. To
> avoid the overflow first perform a right-shift to clear the
> bits that are shifted out.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  include/linux/bitops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> index a83c822c35c2..21dfe63001e3 100644
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -22,7 +22,7 @@
>  	(((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h))))

Once you touche GENMASK_ULL, why not to fix also GENMASK.

>  
>  #define GENMASK_ULL(h, l) \
> -	(((~0ULL) << (l)) & (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h))))
> +	((((~0ULL) >> (l)) << (l)) & (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h))))
>  
>  extern unsigned int __sw_hweight8(unsigned int w);
>  extern unsigned int __sw_hweight16(unsigned int w);
> -- 
> 2.14.0.rc1.383.gd1ce394fe2-goog
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives