linux-kernel - Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c0c49d0-63f4-28d8-7088-2b21ba4d8a3e@tronnes.org>
Date:   Thu, 3 Aug 2017 15:37:49 +0200
From:   Noralf Trønnes <noralf@...nnes.org>
To:     Eric Anholt <eric@...olt.net>, dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.


Den 02.08.2017 22.32, skrev Eric Anholt:
> drm_bridge_remove() is for unregistering a bridge driver, not for
> detaching a bridge from its consumer.
>
> Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
> Signed-off-by: Eric Anholt <eric@...olt.net>
> ---

Acked-by: Noralf Trønnes <noralf@...nnes.org>

>   drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 13481bb6322f..d1e0dc908048 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>   
>   	pm_runtime_disable(dev);
>   
> -	drm_bridge_remove(dsi->bridge);
>   	vc4_dsi_encoder_destroy(dsi->encoder);
>   
>   	mipi_dsi_host_unregister(&dsi->dsi_host);