linux-kernel - Re: [PATCH 23/29] drm/tilcdc: switch to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ed06ee9-6c17-2cb3-f1c4-72901ef7dc17@ti.com>
Date:   Thu, 3 Aug 2017 16:56:04 +0300
From:   Jyri Sarha <jsarha@...com>
To:     Cihangir Akturk <cakturk@...il.com>
CC:     Tomi Valkeinen <tomi.valkeinen@...com>,
        David Airlie <airlied@...ux.ie>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 08/03/17 14:58, Cihangir Akturk wrote:
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() adn should not be
> used by new code. So convert all users of compatibility functions to use
> the new APIs.
> 
> Signed-off-by: Cihangir Akturk <cakturk@...il.com>

Acked-by: Jyri Sarha <jsarha@...com>

This appears to be a part of a larger series. So I guess it will go in
via drm-misc. But if this is not the case just let me know and I'll add
this to my next pull request.

Best Regards,
Jyri

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index d524ed0..6e936dd 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> @@ -75,7 +75,7 @@ static void unref_worker(struct drm_flip_work *work, void *val)
>  	struct drm_device *dev = tilcdc_crtc->base.dev;
>  
>  	mutex_lock(&dev->mode_config.mutex);
> -	drm_framebuffer_unreference(val);
> +	drm_framebuffer_put(val);
>  	mutex_unlock(&dev->mode_config.mutex);
>  }
>  
> @@ -456,7 +456,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
>  
>  	set_scanout(crtc, fb);
>  
> -	drm_framebuffer_reference(fb);
> +	drm_framebuffer_get(fb);
>  
>  	crtc->hwmode = crtc->state->adjusted_mode;
>  }
> @@ -621,7 +621,7 @@ int tilcdc_crtc_update_fb(struct drm_crtc *crtc,
>  		return -EBUSY;
>  	}
>  
> -	drm_framebuffer_reference(fb);
> +	drm_framebuffer_get(fb);
>  
>  	crtc->primary->fb = fb;
>  	tilcdc_crtc->event = event;
>