linux-kernel - Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49o9rwvj46.fsf@segfault.boston.devel.redhat.com>
Date:   Thu, 03 Aug 2017 10:08:57 -0400
From:   Jeff Moyer <jmoyer@...hat.com>
To:     Nikolay Borisov <nborisov@...e.com>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

Nikolay Borisov <nborisov@...e.com> writes:

> We already get the block counts and the calculate the end block at the
> beginning of the function. Let's use the local variables for consistency and
> readability. No functional changes
>
> Signed-off-by: Nikolay Borisov <nborisov@...e.com>

Looks ok to me.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>