[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CA+A7VXUeeWfw7OgrC3He=2_9d-ZMdrKZqQej2ytJCEyJi-H-ug@mail.gmail.com>
Date: Thu, 3 Aug 2017 08:21:15 -0700
From: João Paulo Rechi Vita <jprvita@...il.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Hans de Goede <hdegoede@...hat.com>, linux@...lessm.com,
João Paulo Rechi Vita <jprvita@...lessm.com>,
linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] HID: multitouch: Support Asus T304UA media keys
On Thu, Aug 3, 2017 at 2:24 AM, Jiri Kosina <jikos@...nel.org> wrote:
> On Wed, 2 Aug 2017, Benjamin Tissoires wrote:
>
>> Sorry for the delay. I was at GUADEC the whole past week and couldn't
>> get much kernel work done. I was thinking a little bit about this series
>> though. Patch 1 is fine, but patch 2 is a little bit more of an issue.
>> Ideally, I'd like to keep hid-multitouch from having too many vendor
>> specific code, but it looks like this is the easier way to handle things
>> here.
>>
>> I guess the proper way of solving this situation would be to merge the
>> generic windows 8 code from hid-multitouch into hid-input so that other
>> drivers can benefit from it, but this is going to be a lot of work and
>> -ETIME.
>
> Yes, I actually have this on the list of things I'd eventually like to
> look into one day ... but we shouldn't let this block any further
> development.
>
> I have applied the series now to for-4.14/multitouch (fixing up the
> 0xff310076 -> HID_VD_ASUS_CUSTOM_MEDIA_KEYS constant in the condition as a
> followup).
>
Thanks!
--
João Paulo Rechi Vita
http://about.me/jprvita
Powered by blists - more mailing lists