linux-kernel - Re: [PATCH 2/2] qlcnic: add const to bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5A894F4.157FD1%Harish.Patil@cavium.com>
Date:   Thu, 3 Aug 2017 03:24:37 +0000
From:   "Patil, Harish" <Harish.Patil@...ium.com>
To:     Bhumika Goyal <bhumirks@...il.com>,
        "julia.lawall@...6.fr" <julia.lawall@...6.fr>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Chopra, Manish" <Manish.Chopra@...ium.com>,
        Dept-GE Linux NIC Dev <Dept-GELinuxNICDev@...ium.com>
Subject: Re: [PATCH 2/2] qlcnic: add const to bin_attribute structure

-----Original Message-----
From: Bhumika Goyal <bhumirks@...il.com>
Date: Wednesday, August 2, 2017 at 11:27 PM
To: "julia.lawall@...6.fr" <julia.lawall@...6.fr>, "kvalo@...eaurora.org"
<kvalo@...eaurora.org>, "linux-wireless@...r.kernel.org"
<linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, Harish Patil <Harish.Patil@...ium.com>,
"Chopra, Manish" <Manish.Chopra@...ium.com>, Dept-GE Linux NIC Dev
<Dept-GELinuxNICDev@...ium.com>
Cc: Bhumika Goyal <bhumirks@...il.com>
Subject: [PATCH 2/2] qlcnic: add const to bin_attribute structure

>Add const to bin_attribute structure as it is only passed to the
>functions sysfs_{remove/create}_bin_file. The corresponding
>arguments are of type const, so declare the structure to be const.
>
>Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
>---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>index 73027a6..82fcb83 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
>@@ -1248,7 +1248,7 @@ static ssize_t
>qlcnic_83xx_sysfs_flash_write_handler(struct file *filp,
> 	.write = qlcnic_sysfs_write_pm_config,
> };
> 
>-static struct bin_attribute bin_attr_flash = {
>+static const struct bin_attribute bin_attr_flash = {
> 	.attr = {.name = "flash", .mode = (S_IRUGO | S_IWUSR)},
> 	.size = 0,
> 	.read = qlcnic_83xx_sysfs_flash_read_handler,
>-- 
>1.9.1
>
>Acked-by: Harish Patil <harish.patil@...ium.com>