linux-kernel - Re: [PATCH 4.4 58/83] x86/ioapic: Pass the correct data to unmask_ioapic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1501791863.2047.18.camel@codethink.co.uk>
Date:   Thu, 03 Aug 2017 21:24:23 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Seunghun Han <kkamagui@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4.4 58/83] x86/ioapic: Pass the correct data to
 unmask_ioapic_irq()

On Tue, 2017-07-25 at 12:19 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Seunghun Han <kkamagui@...il.com>
> 
> commit e708e35ba6d89ff785b225cd07dcccab04fa954a upstream.
> 
> One of the rarely executed code pathes in check_timer() calls
> unmask_ioapic_irq() passing irq_get_chip_data(0) as argument.
> 
> That's wrong as unmask_ioapic_irq() expects a pointer to the irq data of
> interrupt 0. irq_get_chip_data(0) returns NULL, so the following
> dereference in unmask_ioapic_irq() causes a kernel panic.
> 
> The issue went unnoticed in the first place because irq_get_chip_data()
> returns a void pointer so the compiler cannot do a type check on the
> argument. The code path was added for machines with broken configuration,
> but it seems that those machines are either not running current kernels or
> simply do not longer exist.
>
> Hand in irq_get_irq_data(0) as argument which provides the correct data.
[...]

This just pushes the null dereference down into io_apic_modify_irq().
Maybe unmask_ioapic_irq() shouldn't be used here at all?

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.