lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 3 Aug 2017 14:43:06 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Himanshu Jha <himanshujha199640@...il.com>
Cc:     johan@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: usb: serial: Replace unsigned to unsigned int
 and fix line over 80 characters

On Fri, Aug 04, 2017 at 02:21:13AM +0530, Himanshu Jha wrote:
> This patch fixes the following checkpatch.pl warnings:
> 
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> WARNING: Missing a blank line after declarations
> WARNING: line over 80 characters
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
> ---
>  drivers/usb/serial/ch341.c | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)

Note, I'm not Johan, but I only take patches that do one thing at a
time, and no, "fixing all coding style issues" is not one thing :)

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ