linux-kernel - Re: [PATCH 056/102] PCI: mediatek: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170803214500.GF20308@bhelgaas-glaptop.roam.corp.google.com>
Date:   Thu, 3 Aug 2017 16:45:00 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, Ryder Lee <ryder.lee@...iatek.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-pci@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 056/102] PCI: mediatek: explicitly request exclusive
 reset control

On Wed, Jul 19, 2017 at 05:26:00PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
> 
> No functional changes.
> 
> Cc: Ryder Lee <ryder.lee@...iatek.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: linux-pci@...r.kernel.org
> Cc: linux-mediatek@...ts.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>

Applied to pci/host-mediatek for v4.14, thanks!

Ryder, Matthias, holler if you see any issues.

> ---
>  drivers/pci/host/pcie-mediatek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
> index 5a9d8589ea0bd..9c9f89bcf24ce 100644
> --- a/drivers/pci/host/pcie-mediatek.c
> +++ b/drivers/pci/host/pcie-mediatek.c
> @@ -303,7 +303,7 @@ static int mtk_pcie_parse_ports(struct mtk_pcie *pcie,
>  	}
>  
>  	snprintf(name, sizeof(name), "pcie-rst%d", index);
> -	port->reset = devm_reset_control_get_optional(dev, name);
> +	port->reset = devm_reset_control_get_optional_exclusive(dev, name);
>  	if (PTR_ERR(port->reset) == -EPROBE_DEFER)
>  		return PTR_ERR(port->reset);
>  
> -- 
> 2.11.0
>