linux-kernel - Re: [PATCH 01/10] agp: uninorth: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1708040801300.9612@skynet.skynet.ie>
Date:   Fri, 4 Aug 2017 08:01:46 +0100 (IST)
From:   Dave Airlie <airlied@...ux.ie>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] agp: uninorth: constify pci_device_id.

On Tue, 1 Aug 2017, Arvind Yadav wrote:

> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

I've merged all the agp ones into drm-next.

Dave.

> ---
>  drivers/char/agp/uninorth-agp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> index fdced54..c381c8e 100644
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -679,7 +679,7 @@ static void agp_uninorth_remove(struct pci_dev *pdev)
>  	agp_put_bridge(bridge);
>  }
>  
> -static struct pci_device_id agp_uninorth_pci_table[] = {
> +static const struct pci_device_id agp_uninorth_pci_table[] = {
>  	{
>  	.class		= (PCI_CLASS_BRIDGE_HOST << 8),
>  	.class_mask	= ~0,
>