linux-kernel - Re: [PATCH v2] zram: Rework copy of compressor name in comp_algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170804010503.GA6084@jagdpanzerIV.localdomain>
Date:   Fri, 4 Aug 2017 10:05:04 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Minchan Kim <minchan@...nel.org>, Nitin Gupta <ngupta@...are.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Doug Anderson <dianders@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v2] zram: Rework copy of compressor name in
 comp_algorithm_store()

On (08/03/17 09:33), Matthias Kaehlcke wrote:
> comp_algorithm_store() passes the size of the source buffer to strlcpy()
> instead of the destination buffer size. Make it explicit that the two
> buffers have the same size and use strcpy() instead of strlcpy().
> The latter can be done safely since the function ensures that the string
> in the source buffer is terminated.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss