linux-kernel - Re: [PATCH v9 11/13] iommu/amd: Don't copy GCR3 table root pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170804122722.GW3431@suse.de>
Date:   Fri, 4 Aug 2017 14:27:22 +0200
From:   Joerg Roedel <jroedel@...e.de>
To:     Baoquan He <bhe@...hat.com>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 11/13] iommu/amd: Don't copy GCR3 table root pointer

On Tue, Aug 01, 2017 at 07:37:27PM +0800, Baoquan He wrote:
> @@ -908,6 +911,14 @@ static int copy_device_table(void)
>  				old_dev_tbl_cpy[devid].data[1]
>  					= old_devtb[devid].data[1];
>  				__set_bit(dom_id, amd_iommu_pd_alloc_bitmap);
> +				/* If gcr3 table existed, mask it out */
> +				if (old_devtb[devid].data[0] & DTE_FLAG_GV) {
> +					tmp = DTE_GCR3_VAL_B(~0ULL) << DTE_GCR3_SHIFT_B;
> +					tmp |= DTE_GCR3_VAL_C(~0ULL) << DTE_GCR3_SHIFT_C;
> +					old_dev_tbl_cpy[devid].data[1] &= ~tmp;
> +					tmp = DTE_GCR3_VAL_A(~0ULL) << DTE_GCR3_SHIFT_A;
> +					old_dev_tbl_cpy[devid].data[0] &= ~tmp;

You also need to clear the DTE_FLAG_GV bit.