linux-kernel - Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ad8cad8-e1a4-57ec-d25f-dc6b0935a6fb@roeck-us.net>
Date:   Fri, 4 Aug 2017 06:47:56 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org, monstr@...str.eu
Cc:     linux-watchdog@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver
 is probed

On 08/04/2017 12:39 AM, Michal Simek wrote:
> Showing message that driver is loaded is common across drivers.

Across watchdog drivers, which I am always half-annoyed about.
Is this really valuable ?

Guenter

> This change also fixes checkpatch (--strict) warning
> "Alignment should match open parenthesis".
> > Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
>   drivers/watchdog/cadence_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index dadd3b0c2d49..064cf7b6c1c5 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -368,7 +368,7 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>   	}
>   	platform_set_drvdata(pdev, wdt);
>   
> -	dev_dbg(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> +	dev_info(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
>   		 wdt->regs, cdns_wdt_device->timeout,
>   		 nowayout ? ", nowayout" : "");
>   
>