linux-kernel - Re: [PATCH] selftests: futex: fix run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170804164034.GB21169@fury>
Date:   Fri, 4 Aug 2017 09:40:34 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     shuah@...nel.org, tglx@...utronix.de, mingo@...hat.com,
        peterz@...radead.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: futex: fix run_tests target

On Wed, Aug 02, 2017 at 07:06:39PM -0600, Shuah Khan wrote:
> On 08/02/2017 06:52 PM, Darren Hart wrote:
> > On Wed, Aug 02, 2017 at 04:31:42PM -0600, Shuah Khan wrote:
> >> make -C tools/testing/selftests/futex/ run_tests doesn't run the tests.
> >> Running run_tests target only when $(OUTPUT) is the $(PWD) is incorrect.
> >> When $(OUTPUT) is empty, run_tests will not run. Fix it.
> >>
> >> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> >> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> > 
> > So this indeed addresses the problem you reported.
> > 
> > I'm curious about why this was changed like it was. I presume to avoid
> > some issues with relative paths, like the ./run.sh and the "cd
> > functional" within run.sh.... but I haven't been able to trigger that.> 
> > When you say $(OUTPUT) is empty - when does that occur? Because if it
> > was in fact "" then the change below would attempt to execute /run.sh
> > ... which is surely not what we want.
> 
> This will not happen. At this stage, OUTPUT will not be empty.
> 
> I didn't explain the condition correctly in my change log. When OUTPUT
> isn't set (which is the usual case when test is run using:
> 
> make -C tools/testing/selftests/futex run_tests
> 
> lib.mk sets it to OUTPUT := $(shell pwd)
> 
> So OUTPUT will be the current directory when run_tests are run.

Thank you for the clarification.

Reviewed-by: Darren Hart (VMware) <dvhart@...radead.org>

-- 
Darren Hart
VMware Open Source Technology Center