linux-kernel - Re: [PATCH 3/3] xen: remove not used trace functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3645b03d-7cda-46f1-3223-87b408b16193@oracle.com>
Date:   Fri, 4 Aug 2017 15:35:06 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
        xen-devel@...ts.xenproject.org, Ingo Molnar <mingo@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3/3] xen: remove not used trace functions

On 08/04/2017 07:36 AM, Juergen Gross wrote:
> There are some Xen specific trace functions defined in
> include/trace/events/xen.h. Remove them.
>
> Signed-off-by: Juergen Gross <jgross@...e.com>

(Again, adding Ingo and Steven)

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>

although I think "s/some Xen/some unused Xen/" in the commit message
would make it clearer.

> ---
>  include/trace/events/xen.h | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/include/trace/events/xen.h b/include/trace/events/xen.h
> index 677e8ac2bb81..1b4fed72f573 100644
> --- a/include/trace/events/xen.h
> +++ b/include/trace/events/xen.h
> @@ -248,16 +248,6 @@ TRACE_EVENT(xen_mmu_set_p4d,
>  		      (int)sizeof(p4dval_t) * 2, (unsigned long long)pgd_val(native_make_pgd(__entry->p4dval)),
>  		      (int)sizeof(p4dval_t) * 2, (unsigned long long)__entry->p4dval)
>  	);
> -
> -TRACE_EVENT(xen_mmu_pud_clear,
> -	    TP_PROTO(pud_t *pudp),
> -	    TP_ARGS(pudp),
> -	    TP_STRUCT__entry(
> -		    __field(pud_t *, pudp)
> -		    ),
> -	    TP_fast_assign(__entry->pudp = pudp),
> -	    TP_printk("pudp %p", __entry->pudp)
> -	);
>  #else
>  
>  TRACE_EVENT(xen_mmu_set_pud,
> @@ -277,16 +267,6 @@ TRACE_EVENT(xen_mmu_set_pud,
>  
>  #endif
>  
> -TRACE_EVENT(xen_mmu_pgd_clear,
> -	    TP_PROTO(pgd_t *pgdp),
> -	    TP_ARGS(pgdp),
> -	    TP_STRUCT__entry(
> -		    __field(pgd_t *, pgdp)
> -		    ),
> -	    TP_fast_assign(__entry->pgdp = pgdp),
> -	    TP_printk("pgdp %p", __entry->pgdp)
> -	);
> -
>  DECLARE_EVENT_CLASS(xen_mmu_ptep_modify_prot,
>  	    TP_PROTO(struct mm_struct *mm, unsigned long addr,
>  		     pte_t *ptep, pte_t pteval),