lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Aug 2017 16:15:48 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Jason Gunthorpe <jgunthorpe@...idianresearch.com>, Stefan Berger <stefanb@...ux.vnet.ibm.com>, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, James Morris <james.l.morris@...cle.com> Subject: [PATCH 4.4 52/91] tpm: fix a kernel memory leak in tpm-sysfs.c 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> commit 13b47cfcfc60495cde216eef4c01040d76174cbe upstream. While cleaning up sysfs callback that prints EK we discovered a kernel memory leak. This commit fixes the issue by zeroing the buffer used for TPM command/response. The leak happen when we use either tpm_vtpm_proxy, tpm_ibmvtpm or xen-tpmfront. Fixes: 0883743825e3 ("TPM: sysfs functions consolidation") Reported-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com> Tested-by: Stefan Berger <stefanb@...ux.vnet.ibm.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> Signed-off-by: James Morris <james.l.morris@...cle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/char/tpm/tpm-sysfs.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/char/tpm/tpm-sysfs.c +++ b/drivers/char/tpm/tpm-sysfs.c @@ -38,6 +38,8 @@ static ssize_t pubek_show(struct device struct tpm_chip *chip = dev_get_drvdata(dev); + memset(&tpm_cmd, 0, sizeof(tpm_cmd)); + tpm_cmd.header.in = tpm_readpubek_header; err = tpm_transmit_cmd(chip, &tpm_cmd, READ_PUBEK_RESULT_SIZE, 0, "attempting to read the PUBEK");
Powered by blists - more mailing lists