linux-kernel - Re: [PATCH 3.18 00/50] 3.18.64-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170805060217.GB6322@1wt.eu>
Date:   Sat, 5 Aug 2017 08:02:17 +0200
From:   Willy Tarreau <w@....eu>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Guenter Roeck <linux@...ck-us.net>, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        shuahkh@....samsung.com, patches@...nelci.org,
        ben.hutchings@...ethink.co.uk, stable@...r.kernel.org
Subject: Re: [PATCH 3.18 00/50] 3.18.64-stable review

On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote:
> On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> > > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > > There are 50 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > > 
> > > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > > Anything received after that time might be too late.
> > > > > 
> > > > 
> > > > Preliminary:
> > > > 
> > > > Lots of
> > > > 
> > > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > > 
> > > > affecting several architectures.
> > > > 
> > > > alpha:
> > > > 
> > > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > > 
> > > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> > 
> > Hm, that doesn't work, do we care about tile? :)
> > 
> > Let me see how deep this hole is, I just wanted to get strscpy into 3.18
> > to fix a bug...
> 
> I suspect you'll need this one which came as part of the strscpy() series
> between 4.2 and 4.3 (though I have not tested) :
> 
>   commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
>   Author: Chris Metcalf <cmetcalf@...hip.com>
>   Date:   Wed Apr 29 12:48:40 2015 -0400
> 
>     Make asm/word-at-a-time.h available on all architectures
>     
>     Added the x86 implementation of word-at-a-time to the
>     generic version, which previously only supported big-endian.
>     (...)

OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips
which previously broke. It will not apply as-is, you'll need to drop the
change for arch/nios2/include/asm/Kbuild, and after that it's OK.

Willy