linux-kernel - Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170805083807.GB14144@lst.de>
Date:   Sat, 5 Aug 2017 10:38:07 +0200
From:   Christoph Hellwig <hch@....de>
To:     Johan Hovold <johan@...nel.org>
Cc:     Christoph Hellwig <hch@....de>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Färber <afaerber@...e.de>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alan Stern <stern@...land.harvard.edu>,
        stable <stable@...r.kernel.org>,
        Robin Murphy <robin.murphy@....com>,
        Sricharan R <sricharan@...eaurora.org>,
        Stefan Wahren <stefan.wahren@...e.com>
Subject: Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA
        during probe

I think the root problem is that the code added by
" of/acpi: Configure dma operations at probe time for platform/amba/pci bus
devices"

is completely bogus and needs to be reverted.  We can't simply iterate
over all devices in the system and set up dma for them.  We'll need
to ask the firmware / OF what root port this applies to and only
apply it to those buses.

Note that the current code checks for a OF or ACPI node already,
so we should start by refining these checks.