linux-kernel - Re: [RESEND PATCH] staging: vboxvideo: remove dead gamma lut code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be539b75-2439-b5f4-af93-bc9a36c5ce6f@redhat.com>
Date:   Sat, 5 Aug 2017 13:11:02 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Peter Rosin <peda@...ntia.se>,
        Daniel Vetter <daniel.vetter@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        vbox-dev@...tualbox.org, Michael Thayer <michael.thayer@...cle.com>
Subject: Re: [RESEND PATCH] staging: vboxvideo: remove dead gamma lut code

Hi,

On 04-08-17 12:45, Peter Rosin wrote:
> The redundant fb helpers .load_lut, .gamma_set and .gamma_get are
> no longer used. Remove the dead code that was not doing anything
> sensible anyway.
> 
> Signed-off-by: Peter Rosin <peda@...ntia.se>

Thank you, patch looks good to me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>   drivers/staging/vboxvideo/vbox_fb.c   | 15 ---------------
>   drivers/staging/vboxvideo/vbox_mode.c |  5 -----
>   2 files changed, 20 deletions(-)
> 
> [This time with an improved Cc list, sorry for the noise. For new
>   people, please refer to https://lkml.org/lkml/2017/7/13/593 for
>   context]
> 
> Hi Daniel,
> 
> Here it goes, but do you really need me to resend v5 14/14?
> 
> Cheers,
> peda
> 
> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
> index 35f6d9f8c203..bf6635826159 100644
> --- a/drivers/staging/vboxvideo/vbox_fb.c
> +++ b/drivers/staging/vboxvideo/vbox_fb.c
> @@ -317,22 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper,
>   	return 0;
>   }
>   
> -static void vbox_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green,
> -			      u16 blue, int regno)
> -{
> -}
> -
> -static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
> -			      u16 *blue, int regno)
> -{
> -	*red = regno;
> -	*green = regno;
> -	*blue = regno;
> -}
> -
>   static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
> -	.gamma_set = vbox_fb_gamma_set,
> -	.gamma_get = vbox_fb_gamma_get,
>   	.fb_probe = vboxfb_create,
>   };
>   
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index f2b85f3256fa..996da1c79158 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -134,10 +134,6 @@ static int vbox_set_view(struct drm_crtc *crtc)
>   	return 0;
>   }
>   
> -static void vbox_crtc_load_lut(struct drm_crtc *crtc)
> -{
> -}
> -
>   static void vbox_crtc_dpms(struct drm_crtc *crtc, int mode)
>   {
>   	struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc);
> @@ -330,7 +326,6 @@ static const struct drm_crtc_helper_funcs vbox_crtc_helper_funcs = {
>   	.mode_set = vbox_crtc_mode_set,
>   	/* .mode_set_base = vbox_crtc_mode_set_base, */
>   	.disable = vbox_crtc_disable,
> -	.load_lut = vbox_crtc_load_lut,
>   	.prepare = vbox_crtc_prepare,
>   	.commit = vbox_crtc_commit,
>   };
>